search

pimatic / rfcontroljs

nodejs modul with protocol support for different 433mhz switches and weather stations for the RFControl Arduino library.
GNU General Public License v3.0
49 stars 54 forks source link

Pull request for 2 new protocols #56

Closed rolandkaeufl closed 9 years ago

rolandkaeufl commented 9 years ago

2 new protocols which only differ in the pulse length. One is for a rolling (Nobily) and the other is for a noname awning. Both types are "command". commands for awning1: out, stop, in commands for rolling2: up and down both: id

If you find somewhere a commit called "Test Upload", please ignore and delete it :-)

Icesory commented 9 years ago

Sorry but the the rolling1 protocol is not for window roller! it is an special protocol which used a rolling code. Please rename your protocol rolling2 to something other.

Icesory commented 9 years ago

and your rolling2 protocol has only 2 states, so it is a nomal switch protocol. Please change the type to switch and up to state true.

rolandkaeufl commented 9 years ago

Did the requested changes.

Icesory commented 9 years ago

Now it looks good. Thanks for your changes.

rolandkaeufl commented 9 years ago

Sorry for the lots of changes. Still fighting with git :-)

sweetpi commented 9 years ago

Hi @rolandkaeufl, thanks for the protocols. Could you do the following:

  1. Backup your changed file to another location.
  2. Run git reset --hard 75c9243e30cbfd312b35afb732090cc9679b39ca This will delete all your changes and commit messages.
  3. Copy back the changed files.
  4. Commit them with git add -A, git commit -a -m "Added awning and nobily protocols", git push.

There's no need to recreate the pull request.