search

pimatic / rfcontroljs

nodejs modul with protocol support for different 433mhz switches and weather stations for the RFControl Arduino library.
GNU General Public License v3.0
49 stars 54 forks source link

Added pir6.js #83

Closed xCite1986 closed 8 years ago

xCite1986 commented 8 years ago

Added Protocol pir6.js for this type of PIR's and window-contact-sensors

mwittig commented 8 years ago

Thanks for you PR. Note however, the protocol must be written in Coffeescript. The JS will be generated. Moreover, you should add test cases for your protocol. See https://github.com/pimatic/rfcontroljs#adding-a-new-protocol for details

EDIT: If you're not familiar with Cofeescript, I can help you. However, I would need some example debug log output to write the tests. Please add the output to this ticket.

sweetpi commented 8 years ago

waiting for coffee file and tests.

xCite1986 commented 8 years ago

@mwittig

I'm sorry, I 'm not familiar with coffee script. with my experience I destroy so only my pimatic-homeduino ^^

you could find some debug-outputs in my issue
https://github.com/pimatic/rfcontroljs/issues/36

short summary what I've done: the pir was detected as switch6 and switch8, so I've taken this protocol, clone'd it and rewrite to a pir...

mwittig commented 8 years ago

I have implemented the coffeescript files and add them to your fork for futher reference. Unfortunately your protocol cannot be decoded with the test data I found in #36 If you have chance to investigate this please do some testing on your fork or get back to me with more test data. I am closing the PR for now.