search

pimax / fb-messenger-php

Facebook Messenger Bot PHP API
GNU General Public License v2.0
314 stars 147 forks source link

add appsecret_proof support, useful for post 2.8 api version #170

Closed gabriel-tandil closed 5 years ago

gabriel-tandil commented 5 years ago

add appsecret_proof support, useful for post 2.8 api version see Securing Graph API Requests - Facebook for Developers

wittfabian commented 5 years ago

Has the change been tested?

jason-engage commented 5 years ago

bonus, semicolon is fixed.

wittfabian commented 5 years ago

TODO: Update CHANGELOG.md

gabriel-tandil commented 5 years ago

Has the change been tested?

Aye aye Sir, well tested :)

gabriel-tandil commented 5 years ago

bonus, semicolon is fixed.

Yeah, that's not a mistake, but it's ugly. See: https://www.php.net/manual/es/language.basic-syntax.instruction-separation.php

gabriel-tandil commented 5 years ago

TODO: Update CHANGELOG.md

Done

o2-web commented 5 years ago

I think it would be cleaner and more beautiful to take app_secret from the config and automatically use it for version v2.8. Thus, we would get rid of the unnecessary parameter in the constructor. Can We Talk?

wittfabian commented 5 years ago

From config?

o2-web commented 5 years ago

From config?

Sent with GitHawk

env('FACEBOOK_APP_SECRET');

o2-web commented 5 years ago

sorry, I forgot it wasn't just for laravel.