search

pimax / fb-messenger-php

Facebook Messenger Bot PHP API
GNU General Public License v2.0
314 stars 147 forks source link

Update minimum PHP version #172

Closed wittfabian closed 5 years ago

wittfabian commented 5 years ago

We should update the minimum PHP version to 7.X.X

jason-engage commented 5 years ago

I'm running it on a php 7 server with no issues.

wittfabian commented 5 years ago

The new tests are also based on php 7

wittfabian commented 5 years ago

https://www.php.net/supported-versions.php

jason-engage commented 5 years ago

This is great, we can start using the ?? Operator (Null Coalesce Operator)

Best operator ever.

wittfabian commented 5 years ago

We should switch to v7.1 with the new tests

jason-engage commented 5 years ago

What about users running on PHP 5? Will you go up a major version? Isn't it set to dev-master in composer? That's always confused me, but I'm not so advanced with composer to begin with.

wittfabian commented 5 years ago

PHP <= 7: "A release that is no longer supported. Users of this release should upgrade as soon as possible, as they may be exposed to unpatched security vulnerabilities. "

major version: yes dev-master composer confuses me too

I will look at the composer settings

wittfabian commented 5 years ago

https://getcomposer.org/doc/articles/aliases.md#branch-alias