search

pimbrouwers / Falco

A toolkit for building fast and functional-first web applications using F#.
https://www.falcoframework.com
Apache License 2.0
530 stars 38 forks source link

Add redirectPermanently and redirectTemporarily functions #80

Closed dpraimeyuu closed 2 years ago

dpraimeyuu commented 2 years ago

This small PR makes redirect capability more verbose by getting rid of additional parameters required from the caller.

Before:

Response.redirect "/" true

After:

Response.redirectPermanentlyTo "/"
pimbrouwers commented 2 years ago

Did you mean to open this one? It looks to be from the same branch in your fork, dpraimeyuu:improvement/develop-make-redirect-fun-verbose-1.

dpraimeyuu commented 2 years ago

79 is from dpraimeyuu:improvement/make-redirect-fun-verbose-1, whereas this PR is has different "prefix": dpraimeyuu:improvement/develop*.

It was just a test to check out gh action build.

dpraimeyuu commented 2 years ago

@pimbrouwers I removed --no-restore from build.yml (according to our Twitter discussion) and build is now green :green_heart:

EDIT:

Also implemented your suggestions from #79 , but this PR (#80) uses different branch, originated from develop (and not from master, as #79 was)

pimbrouwers commented 2 years ago

Much love for this. It was fun working together! Thanks for all the effort. Looking forward to doing it again.