pimcore / admin-ui-classic-bundle

Other
7 stars 95 forks source link

[Task] Remove dependency to `Config` class #43

Open mcop1 opened 1 year ago

mcop1 commented 1 year ago

Config class shouldn´t be used for admin configuration (configuration which are a children to the pimcore_admin node).

For example: Add a configuration for sessions_bags here https://github.com/pimcore/admin-ui-classic-bundle/blob/ae073781a3c5ea1903dcfcbef17586a5c7534c0d/src/DependencyInjection/PimcoreAdminExtension.php#L68 $container->setParameter('pimcore_admin.session.attribute_bags', $config['session']['attribute_bags']);

Then inject the parameter here https://github.com/pimcore/admin-ui-classic-bundle/blob/04af9636a350fd070c53072cae424b64a1ff6957/config/event_listeners.yaml#L42

    Pimcore\Bundle\AdminBundle\EventListener\AdminSessionBagListener:
        arguments:
            $config: ['%pimcore_admin.session.attribute_bags%']
github-actions[bot] commented 8 months ago

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.