pimcore / admin-ui-classic-bundle

Other
11 stars 100 forks source link

Improvement: move annotations to attributes #719

Closed michalananapps closed 1 month ago

michalananapps commented 1 month ago

Migrating annotations from Symfony\Component\Routing\Annotation\Route to attributes has several advantages, which can make project cleaner, more modern, and maintainable. Migrating to attributes is needed to move to newer versions of Symfony in the future.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarCloud

lukmzig commented 1 month ago

@fashxp was there a change in the decision regarding the migration of annotations to attributes? We had a similar PR some time ago and we decided that we would not proceed there, see comment: https://github.com/pimcore/admin-ui-classic-bundle/pull/500#issuecomment-2315500690

fashxp commented 1 month ago

@lukmzig you are right. No other decision or change of priorities. We should not merge this due to our priorities (focus on studio and reducing maintenance efforts for admin-ui-classic to a minimum as it will fade out as soon as studio is ready).

@michalananapps I'm really sorry :face_with_diagonal_mouth:, thank you very much for your efforts though!!

lukmzig commented 1 month ago

@fashxp thank you for the clarification.

@michalananapps thank you for your efforts! I am sorry for this situation but as mentioned we will close this PR in favor of the studio