Closed michalananapps closed 1 month ago
Issues
3 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
1.3% Duplication on New Code
@fashxp was there a change in the decision regarding the migration of annotations to attributes? We had a similar PR some time ago and we decided that we would not proceed there, see comment: https://github.com/pimcore/admin-ui-classic-bundle/pull/500#issuecomment-2315500690
@lukmzig you are right. No other decision or change of priorities. We should not merge this due to our priorities (focus on studio and reducing maintenance efforts for admin-ui-classic to a minimum as it will fade out as soon as studio is ready).
@michalananapps I'm really sorry :face_with_diagonal_mouth:, thank you very much for your efforts though!!
@fashxp thank you for the clarification.
@michalananapps thank you for your efforts! I am sorry for this situation but as mentioned we will close this PR in favor of the studio
Migrating annotations from Symfony\Component\Routing\Annotation\Route to attributes has several advantages, which can make project cleaner, more modern, and maintainable. Migrating to attributes is needed to move to newer versions of Symfony in the future.