[Edit lock] Check for edit lock when editing data, not when opening element

BlackbitDevs commented 1 month ago

Currently when 2 users open the same element, there is this warning:

This confuses users because this even happens if they only want to look up things without changing anything. For this reason this PR changes the behaviour so that the edit lock does not get checked when opening an element but when editing it. As soon as any data of the element gets changed and thus the element gets dirty, the edit lock will get checked. The message in the popup window has been adjusted a bit:

When the user chooses to continue editing (= clicks "Yes"), the edit lock will get released. When the user clicks "No", the element will get closed and reopened.

github-actions[bot] commented 1 month ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

BohdanSheyko commented 1 month ago

I have read the CLA Document and I hereby sign the CLA

mattamon commented 2 weeks ago

@fashxp how will it be done in the new studio ui? Conceptual it sounds good to me.

fashxp commented 2 weeks ago

not finally decided yet. but we have a concept to get notified about remote changes and what you want to do about them. so that edit lock might not be necessary at all anymore.

this change needs to be tested carefully though. maybe someone from the community can help us there?

pimcore / admin-ui-classic-bundle

[Edit lock] Check for edit lock when editing data, not when opening element #724

Quality Gate passed