search

pimcore / advanced-object-search

Advanced Object Search community bundle provides advanced object search in Pimcore backend powered by OpenSearch.
Other
39 stars 44 forks source link

Add PimcoreSimpleBackendSearchBundle to Installer and BundleCollection #203

Closed mattamon closed 1 year ago

mattamon commented 1 year ago

Changes in this pull request

Resolves #202

Additional info

Enabling and installing the PimcoreSimpleBackendSearchBundle in the Bundle and Installer

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

martineiber commented 1 year ago

@mattamon What about the case when someone manually uninstalls the PimcoreSimpleBackendSearchBundle, then the AdvancedObjectSearchBundle is no longer accessible. Should we take this into consideration?

mattamon commented 1 year ago

Fair point, we would have to test it, what will happen, but I guess in this case the Menu won't show up. I guess this is a edge case though.

If you install the PimcoreSimpleBackendSearchBundle manually you have to enable it in the bundles.php and install the bundle. Same goes for the advanced-object-search. It would not really make sense to just uninstall the PimcoreSimpleBackendSearchBundle if you still want to use the advanced-object-search right?

If you only install the advanced-object-search the PimcoreSimpleBackendSearchBundle will be installed automatically and you do not have to enable it in the bundles.php. If you then uninstall the PimcoreSimpleBackendSearchBundle I guess it is your own responsibility.

What bothers me a little is, that if you uninstall the advanced-object-search we cannot simply uninstall the PimcoreSimpleBackendSearchBundle, because we cannot be sure if it is in use or not.

But in general I would say the dev is responsible for the bundle management.

@brusch wdyt?

martineiber commented 1 year ago

I have tested this edge case by uninstalling only the PimcoreSimpleBackendSearchBundle. The search menu is no longer displayed, which means that the AdvancedObjectSearchBundle can no longer be used.

fashxp commented 1 year ago

Fair point, we would have to test it, what will happen, but I guess in this case the Menu won't show up. I guess this is a edge case though.

If you install the PimcoreSimpleBackendSearchBundle manually you have to enable it in the bundles.php and install the bundle. Same goes for the advanced-object-search. It would not really make sense to just uninstall the PimcoreSimpleBackendSearchBundle if you still want to use the advanced-object-search right?

If you only install the advanced-object-search the PimcoreSimpleBackendSearchBundle will be installed automatically and you do not have to enable it in the bundles.php. If you then uninstall the PimcoreSimpleBackendSearchBundle I guess it is your own responsibility.

What bothers me a little is, that if you uninstall the advanced-object-search we cannot simply uninstall the PimcoreSimpleBackendSearchBundle, because we cannot be sure if it is in use or not.

But in general I would say the dev is responsible for the bundle management.

@brusch wdyt?

yes, it is responsibilitiy of bundle management. Do not uninstall bundles automatically...