search

pimcore / data-hub

Data delivery & consumption platform for Pimcore.
Other
127 stars 109 forks source link

Proposal: Be able to filter/search elements by key attribute #293

Open marcogonzalo opened 3 years ago

marcogonzalo commented 3 years ago

Using key attribute as a filter could make simpler some listings like searching an specific category from its slug (the key attribute, for example) or instead of its id, because sometimes the id is not available in the workflow data. Key is an unique attribute so this could be work.

weisswurstkanone commented 3 years ago

@marcogonzalo makes sense, do you want to volunteer and provide a PR?

marcogonzalo commented 3 years ago

Sorry for the late response. Let me talk with my team. We are using Pimcore, but we are not programming on PHP.

weisswurstkanone commented 3 years ago

@marcogonzalo Great, many thanks! Awaiting your feedback 👍

marcogonzalo commented 3 years ago

Hello, @weisswurstkanone. My partner @PanchoMrlda is going to try to do this. Do you have some orientations about it? It's our first time on it and we need to try to make it quickly :-$

weisswurstkanone commented 3 years ago

I would start here (extending the schema) https://github.com/pimcore/data-hub/blob/18f0a8618be0a7659f86c81a3ca542280130300a/src/GraphQL/Query/QueryType.php#L277

and here (doing the filtering)

https://github.com/pimcore/data-hub/blob/58414f5c996087bdad7189d0a7c9a10503a3337b/src/GraphQL/Resolver/QueryType.php#L336

github-actions[bot] commented 9 months ago

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.