search

pimcore / data-hub

Data delivery & consumption platform for Pimcore.
Other
124 stars 105 forks source link

Crop Image #321

Open do-web opened 3 years ago

do-web commented 3 years ago

If i crop an image then the image in graphql output is not cropped. I receive only the crop data in graphql.

Bildschirmfoto 2021-02-12 um 17 53 04

weisswurstkanone commented 3 years ago

Hi @do-web , could you paste a request sample which I could use directly on the demo instance for investigations?

do-web commented 3 years ago

Image fullpath and/or resolutions do not contain the cropped image.

{
  getImageElement(id: 123) {
    image {
      crop {
        cropTop
        cropLeft
        cropHeight
        cropWidth
      }

      image {
        fullpath
        filename

        resolutions(thumbnail: "ImageTeaser", types: [1, 2]) {
          url 
          resolution
        }
      }
    }
  }
}
weisswurstkanone commented 3 years ago 
  crop {
    cropTop
    cropLeft
    cropHeight
    cropWidth
  }

provides some "dynamic" cropping values, but as far as I see it you also provide a thumbnail name.

What would be the expectation?

do-web commented 3 years ago

That the images are already output cropped.

weisswurstkanone commented 3 years ago

Hello @julmot , seems that this got broken, at least with error reporting set to E_ALL. Could you please have a look if you find some thing. See https://github.com/pimcore/data-hub/pull/221

julkue commented 3 years ago

Sorry, we don't have time to look into this at the moment.

weisswurstkanone commented 3 years ago

@julmot 🏓 what about now ? 😄

github-actions[bot] commented 7 months ago

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.