Closed noahcommandeur-twocream closed 2 months ago
Ouh sry I forgot to commit on 08.08 I'm back from vacation then I'll take care of it
Hey @noahcommandeur-twocream,
First of all, thank you for your PR! The functionality in the video looks really handy.
One minor thing for your PR though. You do not need to change all the translation files. The English version is enough. The translation get synced to POEditor https://poeditor.com/ get translated there and we get the translations back as a PR. Could you please remove all the other translations? :)
Thank you in advance!
Issues
34 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
17.5% Duplication on New Code
Good morning @mattamon ,
All right, thanks for the feedback :) In the future I will know that I only have to take care of the English translation Is adapted!
Greetings Naoh
Hi, thanks for the feedback, I'll take another look at the item click function and optimize it, then I'll expand the upgrade notes :)
Regards Noah
Hi, thanks for the feedback, I'll take another look at the item click function and optimize it, then I'll expand the upgrade notes :)
Regards Noah
Thank you Noah! Appreciate the effort you are putting in!
@noahcommandeur-twocream just saw this PR - fantastic idea to add this button.
Are there any updates? I would love to put it into today's release :man_astronaut: :rocket:
Unfortunately I haven't quite got around to it yet, but I'll manage it in the next few days, maybe even today in the course of the day... otherwise as a FollowUP during the days?
otherwise as a FollowUP during the days?
@noahcommandeur-twocream sure. You can also create a follow-up PR. Do you have a few minutes to tell the world about your improvement in the 1.8 upgrade notes?
:man_astronaut: :rocket:
Well then I will add a code cleanup as a follow up :) I have opened a PR for the changes to the upgrade notes. if you want to refine the text a little more you are welcome to do so :) https://github.com/pimcore/data-hub/pull/884
@noahcommandeur-twocream Thanks for the quick reply - now this PR can be part of the 1.8 release :100: :1st_place_medal:
Changes in this pull request
Added a button that adds all definitions except for the system columns. Furthermore, multi drag and drop has been added with STR + click you can select several fields and drag them over to the configuration.
You can deselect multiple fields and remove them from the configuration again
Button for delete complete configuration fixed
And category selector added ( STR + click ) on a category
Additional info
https://github.com/user-attachments/assets/e494d937-f23e-4015-ae0a-7e57df561ad4