search

pimcore / data-hub

Data delivery & consumption platform for Pimcore.
Other
128 stars 110 forks source link

[Task]: Replace Request::get with explicit input sources #874

Closed kingjia90 closed 2 months ago

kingjia90 commented 3 months ago

Resolves https://github.com/pimcore/data-hub/issues/679 Related https://github.com/pimcore/pimcore/issues/14138

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mattamon commented 3 months ago

@kingjia90 What does it need to be finished? Could we already merge it?

kingjia90 commented 2 months ago

Do we also need to update

https://github.com/pimcore/data-hub/blob/836c6906b2a8238f51cbee477dd14319b84740b3/doc/10_GraphQL/10_Events.md#L260

& https://github.com/pimcore/data-hub/blob/836c6906b2a8238f51cbee477dd14319b84740b3/doc/10_GraphQL/10_Events.md#L273

?

no needed because it's not marked as internal https://github.com/symfony/http-foundation/blob/f602d5c17d1fa02f8019ace2687d9d136b7f4a1a/Request.php#L1125-L1138 and itself seems using the right explicit source approach https://github.com/symfony/http-foundation/blob/f602d5c17d1fa02f8019ace2687d9d136b7f4a1a/Request.php#L1153

mcop1 commented 2 months ago

Ok, then it looks good to me, thanks :)