pimcore / data-hub

Data delivery & consumption platform for Pimcore.
Other
128 stars 110 forks source link

Do not store CORS headers in output cache #896

Closed gajdusek closed 1 month ago

gajdusek commented 1 month ago

Ensure that that dynamic Access-Control-Allow-Origin header is not cached.

This resolves issue (#895) with CORS headers being cached alongside GraphQL responses, which could cause incorrect Access-Control-Allow-Origin values for clients with different origins.

github-actions[bot] commented 1 month ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

gajdusek commented 1 month ago

This does not fix the issue entirely. I am experiencing responses with missing Access-Control-Allow-Origin. Going to look into it.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gajdusek commented 1 month ago

This does not fix the issue entirely. I am experiencing responses with missing Access-Control-Allow-Origin. Going to look into it.

It's fixed.

gajdusek commented 1 month ago

I have read the CLA Document and I hereby sign the CLA

mcop1 commented 1 month ago

LGTM, thank you!

mcop1 commented 1 month ago

Cherry picked to 1.8 -> https://github.com/pimcore/data-hub/commit/b71636ac4a1a4c7f03259b720f52a2f13e313543