search

pimcore / data-importer

This extension adds a comprehensive import functionality to Pimcore Datahub.
Other
38 stars 56 forks source link

[Feature] Add SQL Data Source #379

Open msoroka opened 9 months ago

msoroka commented 9 months ago

Originally created by LemonMind and TorqIT on Data Importer Extension.

All explained in attached docs.

mattamon commented 1 month ago

Hey @msoroka

Unfortunately the static analysis failed, could you please recheck your code and fix the tests.

mattamon commented 2 days ago

Hey @msoroka are you still working on this? It seems like a pretty cool feature, but with failing tests we cannot merge it.

Could you give me a quick comment, that you are going to fix this? Otherwise I will close the PR in a week. If you still want this, we can reopen the PR anytime then.

msoroka commented 2 days ago

@mattamon Yes, I'll do it till end of this week.

mattamon commented 2 days ago

@mattamon Yes, I'll do it till end of this week.

Awesome thank you!

msoroka commented 2 days ago

@mattamon Done