pimcore / data-importer

This extension adds a comprehensive import functionality to Pimcore Datahub.
Other
38 stars 56 forks source link

Skip UTF8 byte order mark in CSV files #407

Closed mdurys closed 2 months ago

mdurys commented 3 months ago

Currently if a CSV file contains a byte order mark it is treated as data. This is visible on this screenshot from Pimcore Enterprise Demo:

Screenshot from 2024-05-20 13-41-32

The data for row 0 (id) is in quotes, because it also contains byte order mark which is interpreted as a white space.

This MR changes that by skipping UTF8 byte order mark.

Sample CSV file: test_utf8_bom.csv

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mdurys commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

Corepex commented 2 months ago

@mdurys, thanks for your PR :100: