pimcore / docker

73 stars 50 forks source link

Andand #91

Closed cipribucur closed 2 years ago

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

jdreesen commented 2 years ago

What is the advantage of this?

brusch commented 2 years ago

@jdreesen see https://unix.stackexchange.com/questions/37069/what-is-the-difference-between-and-when-chaining-commands#:~:text=190,whatever%20command1%20returned.

So basically it makes the building process more reliable.

jdreesen commented 2 years ago

Not really, as you already call set -eux; (with e being the important part here) which makes ; behave the same as && because the shell exits with an error if one command fails.

See: https://unix.stackexchange.com/questions/37069/what-is-the-difference-between-and-when-chaining-commands/37085#37085:~:text=You%20can%20tell%20the%20shell%20to%20enter%20%E2%80%9Cexit%20on%20error%E2%80%9D%20mode%20by%20running%20set%20%2De.

brusch commented 2 years ago

@jdreesen thanks for clarifying - didn't see 😊