Entrypoint.sh: Start xdebug on request removed

pimcore / docker

73 stars 50 forks source link

Entrypoint.sh: Start xdebug on request removed #95

Closed MarkTro closed 2 years ago

MarkTro commented 2 years ago

You can start the debugging with an .env variable or by a cookie setting, see https://xdebug.org/docs/all_settings#start_with_request. Without starting the debugging on request by default, the image is also usable in prod environment or at least you have the choice if you want debugging in an environment or not.

CLAassistant commented 2 years ago

All committers have signed the CLA.

jdreesen commented 2 years ago

Should we document this somehow? Apparently it's some kind of breaking change.

dpfaffenbauer commented 2 years ago

I would add versioning to images first and then add this. Currently these images are not versioned and don’t allow BC breaks

brusch commented 2 years ago

Hmmm, I'm just thinking whether this should be really considered as a BC break or not, as only the -debug images are affected which shouldn't go on prod anyway ... 🤔 Debugging in the browser wouldn't change at all in most cases, just on the commandline. My feeling is that would be acceptable, as it's just about debugging and not breaking any application functionality. WDYT?

brusch commented 2 years ago

Fixed by #104