search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 30 forks source link

Update AbstractConfig.php #114

Closed j-jonas closed 1 year ago

j-jonas commented 1 year ago

Typed property Pimcore\Bundle\EcommerceFrameworkBundle\IndexService\Config\AbstractConfig::$searchAttributes must not be accessed before initialization

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

blankse commented 1 year ago

@j-jonas The target branch should be 1.0 because it's a bug.

kingjia90 commented 1 year ago

@j-jonas Thank you for the PR, please also sign the CLA beside rebasing

dvesh3 commented 1 year ago

Closed in favor of #115 @j-jonas Thanks!