search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 30 forks source link

Fix Codeception tests #117

Closed blankse closed 1 year ago

blankse commented 1 year ago

See https://github.com/pimcore/ecommerce-framework-bundle/actions/runs/5890946184/job/15977053591?pr=116

In JUnitReporter.php line 250:

Error: r]                                                                      
  Call to private method PHPUnit\Framework\TestCase::hasExpectationOnOutput()  
   from scope Codeception\Reporter\JUnitReporter
blankse commented 1 year ago

The failed test with 11.x-dev is fixed with https://github.com/pimcore/ecommerce-framework-bundle/pull/116 and release of 11.0.7

aryaantony92 commented 1 year ago

@blankse Do we need this PR? Because this PR https://github.com/pimcore/ecommerce-framework-bundle/pull/116 will fix the codeception.

aryaantony92 commented 1 year ago

@blankse And the reported error is from Codeception/PHP Unit itself https://github.com/Codeception/Codeception/issues/6680

robertSt7 commented 1 year ago

@blankse Could you please merge 1.0 in your branch? Thanks :)

blankse commented 1 year ago

@robertSt7 Done :)

robertSt7 commented 1 year ago

@blankse Thanks a lot :)