search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 30 forks source link

fix: Environment::setCurrentCheckoutTenant() compares wrong variable #130

Closed das-peter closed 10 months ago

das-peter commented 11 months ago

Environment::setCurrentCheckoutTenant() should compare the variable it always adjusts in order to detect changes and not the one that is only conditionally adjusted.

github-actions[bot] commented 11 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

das-peter commented 11 months ago

I have read the CLA Document and I hereby sign the CLA

And hereby will be except from all further pimcore trainings in eternity

dvesh3 commented 11 months ago

recheck

dvesh3 commented 10 months ago

@das-peter could you please comment again just the CLA line? thanks!

das-peter commented 10 months ago

I have read the CLA Document and I hereby sign the CLA

dvesh3 commented 10 months ago

@das-peter one last thing. please rebase it on 1.0 branch.

robertSt7 commented 10 months ago

@das-peter Please create a new PR with your changes from 1.0 or do a force push, to not have all the other commits in your PR. Thanks

dvesh3 commented 10 months ago

pushed directly to 1.0 branch https://github.com/pimcore/ecommerce-framework-bundle/commit/736a02784113ba83190fad0070ad515bb14a93e9. thanks!