search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
10 stars 33 forks source link

Add admin order note user check #133

Closed valentin- closed 11 months ago

valentin- commented 11 months ago

Currently an error occurs when the user in the note object is empty.

Pimcore\Model\User\AbstractUser::getById(): Argument #1 ($id) must be of type int, null given, called in /app/vendor/pimcore/ecommerce-framework-bundle/src/Controller/AdminOrderController.php on line 332

github-actions[bot] commented 11 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

valentin- commented 11 months ago

I have read the CLA Document and I hereby sign the CLA

valentin- commented 11 months ago

recheck

valentin- commented 11 months ago

recheck

dvesh3 commented 11 months ago

@valentin- please rebase on 1.0 branch since this is a fix. thanks!

valentin- commented 11 months ago

@dvesh3 how can I push the rebase from my fork on 1.0 to this PR, or should i create a new PR?

dvesh3 commented 11 months ago

@valentin- yes, please create a new PR based on 1.0 and close this one. thanks!