search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 30 forks source link

Gracefully handle non-existing tokens in voucher token condition #135

Closed jdreesen closed 10 months ago

jdreesen commented 10 months ago

When the token does not exist, VoucherServiceToken::getByCode() will return null, which results in a Call to a member function getVoucherSeriesId() on null exception instead of returning a boolean in checkVoucherCode().

dvesh3 commented 10 months ago

@jdreesen 1.0 branch?

jdreesen commented 10 months ago

Right, it's already broken in Pimcore 10.