search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 28 forks source link

[Bug]: Price filter "not implemented yet" #141

Open Fabian-Hofer-Mastertent opened 8 months ago

Fabian-Hofer-Mastertent commented 8 months ago

Expected behavior

I made a custom price filter and added a price condition to the product list. Expected would be that the ecommerce-framework handles the filter and sorting when the price filter is set.

Actual behavior

Adding the price condition results in an "Not implemented yet"-Exception because two of the four functions in the Pimcore\Bundle\EcommerceFrameworkBundle\IndexService\ProductList\DefaultMySql are not implemented yet. There are four functions in the class that handle the four cases:

the last two functions are not implemented.

I think i could extend the DefaultMySql class somehow and write the functions myself, but I have a bit difficulty to override them correctly because the ecommerce-config does not give me any options to do that. (like with the MySqlConfig or Worker classes)

Steps to reproduce

  1. Create your own FilterTye (i named mine "PriceFilter") that extends the AbstractFilterType
  2. in the addCondition function call the "$priceFilter->addPriceCondition" function with from and to price
  3. add the new FilterType to your filter
github-actions[bot] commented 6 months ago

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.