search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 31 forks source link

[Bug]: SelectFromMultiSelect -> trim(null) #144

Closed 80Quattro closed 9 months ago

80Quattro commented 9 months ago

Expected behavior

SelectFromMultiSelect works also if $value == AbstractFilterType::EMPTY_STRING

Actual behavior

trim(): Argument #1 ($string) must be of type string, null given

An Exception is thrown if $value == AbstractFilterType::EMPTY_STRING in SelectFromMultiSelect

SelectFromMultiSelect.php, line 66 -> There is assigned null to $value,

then, in line 72, function trim($value) is called -> trim(null) is not allowed in PHP: doku

Steps to reproduce

-

kingjia90 commented 9 months ago

Thank you!

Fixed by https://github.com/pimcore/ecommerce-framework-bundle/pull/145