search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 28 forks source link

Add setCustomProperties method to CartItemInterface #146

Open dblaichinger opened 7 months ago

dblaichinger commented 7 months ago

Overview

In order to avoid BC-BREAK in https://github.com/pimcore/ecommerce-framework-bundle/pull/143, the extension of CartItemInterface was removed there. See: https://github.com/pimcore/ecommerce-framework-bundle/pull/143#issuecomment-1857850653

This pull request will extend the CartItemInterface again, as the method setCustomProperties should be defined there. Please add label BC-BREAK here and consider it when creating next major release.

Thank you!

dblaichinger commented 5 months ago

Hi @fashxp,

just wanted to check back regarding https://github.com/pimcore/ecommerce-framework-bundle/pull/143#issuecomment-1926685356.

Do you suggest to add a new field params and add it to \CartManager\CartItem\Dao::$fieldsToSave to be saved automatically?

Thanks, Daniel

fashxp commented 3 months ago

@dblaichinger sorry for not coming back earlier, I missed that comment :(

yes, I was thinking of saving this additional data automatically. Not sure, what is necessary for that all though out of my head ... probably depends on the cart implementation, as the db cart will need some additional database table and some strategy to save this data (e.g. as json or something similar).