search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 28 forks source link

SelectCategory.php: Cast $value to string #154

Closed MarkTro closed 6 months ago

MarkTro commented 6 months ago

$value can set with an int value (line 73) by "getId()". Trim throws in strict mode an error, if it doesn't get a string. Therefore we need to cast $value to a string.

github-actions[bot] commented 6 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

MarkTro commented 6 months ago

I have read the CLA Document and I hereby sign the CLA

fashxp commented 6 months ago

thx very much.

fashxp commented 6 months ago

but could you please rebase to 1.0 branch

fashxp commented 6 months ago

sadly that didn't work out. you need to rebase (not merge) your local branch to 1.0 and then force-push to remote.

MarkTro commented 6 months ago

Hey @fashxp , I tried to rebase the branch, but there suddenly some commit in it which wasn't mine. Therefore I created a new MR based on branch 1.0: https://github.com/pimcore/ecommerce-framework-bundle/pull/156

I close this one.

fashxp commented 6 months ago

thx very much