search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 28 forks source link

[bugfix] Fix voucher token max usage limit #157

Closed dolmit-tanel-paaro closed 3 months ago

dolmit-tanel-paaro commented 5 months ago

Before the change, this situation was possible:
image

The expected behavior is that you can't apply a voucher token that has reached it's limit. The actual behavior is that the voucher token's limit is usages + 1.

github-actions[bot] commented 5 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

blankse commented 5 months ago

@dolmit-tanel-paaro The target branch should be 1.0 because it is a bug fix.

dolmit-tanel-paaro commented 5 months ago

@dolmit-tanel-paaro The target branch should be 1.0 because it is a bug fix.

Thanks, rebased.

dolmit-tanel-paaro commented 5 months ago

I have read the CLA Document and I hereby sign the CLA

dolmit-tanel-paaro commented 5 months ago

recheck

markus-moser commented 3 months ago

Thanks a lot!