search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 28 forks source link

Array flip makes voucher strings to int #161

Closed Daniel-Ateles closed 3 months ago

Daniel-Ateles commented 5 months ago

When adding voucher-tokens that are all numbers the array_flip function will make the values to int's so we need to cast to string in OrderManager. We also need to cast to int when reading configuration->getUsages() because it returns string.

fashxp commented 5 months ago

thx very much. could you please rebase to 1.0 branch

fashxp commented 4 months ago

@Daniel-Ateles :ping_pong:

Daniel-Ateles commented 4 months ago

@Daniel-Ateles 🏓

I have to admit I'm not sure how to rebase to 1.0 branch. Can one do it directly here from github?

fashxp commented 4 months ago

@Daniel-Ateles 🏓

I have to admit I'm not sure how to rebase to 1.0 branch. Can one do it directly here from github?

sadly not, as it would contain the 1.x commits. needs to be done via git ... checkout, rebase branch to 1.0 and then force push the branch (to make sure the 1.x commits are gone). and then we can rebase the PR here it github.

fashxp commented 3 months ago

merged and cherry-picked https://github.com/pimcore/ecommerce-framework-bundle/commit/49109e84242d335fa7175159305a8f0cc0837fa0