search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
8 stars 28 forks source link

Cast value to string for selectCategory #169

Closed AlternateIf closed 4 months ago

AlternateIf commented 4 months ago

trim might cause an error in case of an actual id (int) being given instead of a string. cast to string to avoid this (see https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/FilterService/FilterType/ElasticSearch/SelectCategory.php#L73)

github-actions[bot] commented 4 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

AlternateIf commented 4 months ago

I have read the CLA Document and I hereby sign the CLA

fashxp commented 4 months ago

Thx very much, please rebase to 1.0

AlternateIf commented 4 months ago

Thx very much, please rebase to 1.0

@fashxp so adding the original repo as upstream and doing a rebase on the 1.0 branch (git rebase upstream/1.0) right?

blankse commented 4 months ago

@AlternateIf You need to use the --onto option. Otherwise you still have the commits from 1.x in the branch. git rebase --onto origin/1.0 origin/1.x Than you have to use the force push: git push --force

AlternateIf commented 4 months ago

just saw that this was already resolved in 1.0.11 by https://github.com/pimcore/ecommerce-framework-bundle/commit/6ebfd3e4ee03da53d4ab7fbfb2ab466ff9d64bcd

i am going to close this