Open mlumia opened 7 months ago
Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.
Expected behavior
Setting a custom Tracking Manager in the config
tracking_manager_id
should output the tracked codes for the active GoogleTagManager tracker.The event subscriber TrackingCodeFlashMessageListener should move the flash message tracked codes to the Tracker tracked codes.
The event subscriber TrackingCodeSubscriber should prepend the tracked codes to the
GoogleTagManagerEvents
event block.Info: The use of the Factory is required to get the TrackingManager. Using DI is incorrect. The documentation example also show the use of DI as the "method" to implement, which is incorrect.
Actual behavior
Both EventSubscribers (TrackingCodeSubscriber and TrackingCodeFlashMessageListener) use DI to get the TrackingManager which is not loaded with the $trackers from the compiler pass.
The tracked codes by the tracking_manager_id TrackingManager is not output.
Steps to reproduce
tracking_manager_id
as the custom TrackingManager class$this->factory->getTrackingManager()->trackProductView($product);
$this->factory->getTrackingManager()->forwardTrackedCodesAsFlashMessage();
dataLayer.push
which is not output.