search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
11 stars 33 forks source link

[Improvement]: Change filter definition's page limit from float to int #195

Open dolmit-tanel-paaro opened 2 months ago

dolmit-tanel-paaro commented 2 months ago

Improvement description

I'm proposing this change because I recently run into an issue where I programmatically set filter definition's page limit:
$filterDefinition->setPageLimit(PHP_INT_MAX)

As page limit is float, PHP_INT_MAX gets converted to float: 9.2233720368548E+18
This resulted in SQL syntax error.

I don't see any practical reason for page limit to be float - you won't be loading half or 1.2 items at a time.

Ref: https://github.com/pimcore/ecommerce-framework-bundle/blob/5e105cfd9bd4c9ff1824905356be5a8c5c468091/src/Model/AbstractFilterDefinition.php#L33

github-actions[bot] commented 1 month ago

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.