Closed mysliwietzflorian closed 1 year ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
With this change, a developer can react to different state updates from the API.
In our case, we see it as a critical error, when the new state is considered successful but was already aborted. Otherwise, we just log it normally.
What do you think?
For me this is a valid improvement, the only problem I do see, is like if someone already caught the UnsupportedException then he has to change to the new Exception now, so it would be a BC right, unless you could still catch this exception with an UnsupportedException check?
[...] if someone already caught the UnsupportedException then he has to change to the new Exception now, so it would be a BC right
We could extend UnsupportedException instead of AbstractEcommerceException. Would that solve your concern? @mattamon
[...] if someone already caught the UnsupportedException then he has to change to the new Exception now, so it would be a BC right
We could extend UnsupportedException instead of AbstractEcommerceException. Would that solve your concern? @mattamon
I guess so, I would still need to test it :) But that would be better, for a smooth upgrade, since 11.0.0 will be today and we cannot do any BCs anymore :)
@mattamon I've pushed the changes.
Good luck with the update! 😉
With this change, a developer can react to different state updates from the API.
In our case, we see it as a critical error, when the new state is considered successful but was already aborted. Otherwise, we just log it normally.
What do you think?