search

pimcore / generic-data-index-bundle

Other
3 stars 2 forks source link

Add indexing mechanism for documents #100

Closed lukmzig closed 6 months ago

lukmzig commented 6 months ago

Changes in this pull request

Resolves https://github.com/pimcore/generic-data-index-bundle/issues/96 Resolves #97

Additional info

Please note that fields in different document types might change based on the API requirements. I just prepared them and added fields are based on the models in the core.

github-actions[bot] commented 6 months ago

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
github-actions[bot] commented 6 months ago

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
lukmzig commented 6 months ago

Please add some basic functional tests at least like this:

https://github.com/pimcore/generic-data-index-bundle/blob/1.x/tests/Functional/SearchIndex/DataObjectBasicTest.php

The functional tests setup works similar to the portal engine

Done with https://github.com/pimcore/generic-data-index-bundle/pull/100/commits/27f02d482bafef244ab3155510eacdca526b88c4