search

pimcore / generic-data-index-bundle

Other
3 stars 1 forks source link

[Improvement] Search will not return an item if user has no view permission on parent of the parent folder #131

Closed markus-moser closed 2 months ago

markus-moser commented 3 months ago

Fixes #73

github-actions[bot] commented 3 months ago

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
lukmzig commented 2 months ago

@markus-moser maybe you need to again merge changes from 1.x into your branch to resolve merge conflicts. Also then probably you will have some qodana "errors" like here: https://github.com/pimcore/generic-data-index-bundle/pull/131/files#diff-8c3f927628d7b4ec012df95194fbbedbda0cfbc1b86af912c11fc19a7bb81e83R38

this class can be readonly

markus-moser commented 2 months ago

@markus-moser maybe you need to again merge changes from 1.x into your branch to resolve merge conflicts. Also then probably you will have some qodana "errors" like here: https://github.com/pimcore/generic-data-index-bundle/pull/131/files#diff-8c3f927628d7b4ec012df95194fbbedbda0cfbc1b86af912c11fc19a7bb81e83R38

this class can be readonly

Thanks I merged it again. Qodana did not find any problems. The mentionend class cannot be readonly because of the LoggerAwareTrait :)