pimcore / generic-data-index-bundle

Other
4 stars 4 forks source link

Index errors with Object Brick fields #232

Closed rliebi closed 2 weeks ago

rliebi commented 1 month ago

Changes in this pull request

Resolves index errors for fields within object bricks (e.g Date) see #228

Additional info

lukmzig commented 4 weeks ago

@rliebi thank you very much for your contribution. You are right, without normalize this would lead to a problem. We noticed that we are missing some other containers still and we created an issue where we would like to address them all.

https://github.com/pimcore/generic-data-index-bundle/issues/233

Furthermore, I wanted to ask if your approach resolves the issue, because the normalization differs between object bricks and field collections.

rliebi commented 3 weeks ago

@lukmzig it works for us. the only issues we still have are some video element related ones.

lukmzig commented 2 weeks ago

@rliebi thank you for the PR once again, as mentioned I will close it in favor of https://github.com/pimcore/generic-data-index-bundle/pull/240

240 PR is adding missing custom normalize methods for containers