pimcore / generic-data-index-bundle

Other

3 stars 1 forks source link

PD-95 Add field collection adapter. #40

Closed martineiber closed 4 months ago

martineiber commented 4 months ago

Changes in this pull request

Resolves https://pimcore.atlassian.net/browse/PD-95

Additional info

github-actions[bot] commented 4 months ago

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions

martineiber commented 4 months ago

@martineiber would it make sense to add a unit test for this adapter?

Yeah definitely. But there we first need the Static Resolver Bundle to get rid of the static call FieldCollectionDefinition::getByKey

I will add the static resolver bundle here and Provide a Unit Test.