pimcore / generic-data-index-bundle

Other
3 stars 1 forks source link

Asset meta data filters #94

Closed markus-moser closed 3 months ago

markus-moser commented 4 months ago
github-actions[bot] commented 4 months ago

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
martineiber commented 3 months ago

https://github.com/pimcore/pimcore/pull/16725 Is already merged. So we can add those value Objects?

markus-moser commented 3 months ago

pimcore/pimcore#16725 Is already merged. So we can add those value Objects?

Yes, I will use them in this PR. Could you please check the other cases in the generic data index bundle?

markus-moser commented 3 months ago

pimcore/pimcore#16725 Is already merged. So we can add those value Objects?

Value objects are replaced with the ones from the core now.