search

pimcore / output-data-config-toolkit

Output Data Config Toolkit community bundle adds some additional tools for formatting data outputs to Pimcore.
Other
21 stars 22 forks source link

[Improvement]: Decouple the bundle from ecommerce bundle #89

Closed aweichler closed 1 year ago

aweichler commented 1 year ago

Improvement description

I saw that this Bundle (v5) requires the ecommerce bundle, which is only used in one class. The ecommerce bundle has many dependencies. Do you think it is possible to decouple the output data bundle from the ecommerce bundle? Maybe with an interface? Or with checking if DefaultMockup class exists.

dvesh3 commented 1 year ago

@aweichler yes, you are right. we should not require ecommerce bundle just for one reference. I have kicked the bundle requirement and added class_exists to checks https://github.com/pimcore/output-data-config-toolkit/pull/91. thanks for your report 😊