search

pimcore / personalization-bundle

Personalization community bundle provides personalization features such as behavioral targeting, visitor profiling and personalized content for Pimcore.
https://pimcore.com/docs/platform/Targeting/
Other
2 stars 7 forks source link

Bump lcobucci/jwt to version 5 (#11) #72

Closed youwe-petervanderwal closed 7 months ago

youwe-petervanderwal commented 7 months ago

This resolves issue #11 which seems the last task for version/milestone 1.1.

That same milestone includes the PHP8.3 support. With upcoming Ubuntu 24.04 we'd really like to be ready to upgrade our clients.

As suggested by @fashxp in the issue I went with the ^4.0 || ^5.0 approach to avoid BC breaks. I tested them on both versions in the demo project.

Only change needed was that the builder is immutable as of 5.0. As those methods returned $this in 4.0, no hacks were needed to support both versions.

markus-moser commented 7 months ago

Great, thanks a lot!