search

pimcore / perspective-editor

Perspective Editor community bundle provides a management UI for Pimcore perspectives.
https://pimcore.com/docs/platform/Perspective_Editor/
Other
20 stars 11 forks source link

[Bug]: Allow Objects settings saved wrong as array instead of comma separated list #144

Closed ascheider closed 12 months ago

ascheider commented 1 year ago

Expected behavior

I want to add a new object view with class assignment and save it without losing assigned classes on all existing views.

Actual behavior

I create a new view of type object and assign the class. After save all class assignments are lost, because they are saved as array instead of comma separated list.

Steps to reproduce

Create a view and assign classes to it and save the changes: image Reload the admin and open View Editor again. Add new view of type object and select also the object and save: image Reload the admin again and open the first view, object selection is gone: image If you take a look in the database, the classes are stored as array, instead of comma separated list: image If you reassign the class in the view and save again, the classes are stored as comma separated string again and view the objects correct. image

I tested the issue in pimcore 10.5 with Bundle Version 1.5.1 and also pimcore 11 with 1.6.1 and can reproduce it in both. The bug is pretty critical, it breaks all existing views after creation of the new view. If would be good if it can be fixed in both versions 1.5.2 and 1.6.2.

I inspected also the request, the data which is sent to the server has already wrong payload: image Maybe some serialization or encoding issue.

dvesh3 commented 12 months ago

Fixed by #146

ascheider commented 12 months ago

@dvesh3 Thanks for the bugfix. Any chance to release the new versions soon?

dvesh3 commented 12 months ago

@ascheider new release 1.6.2 is tagged which includes the fix.

ascheider commented 12 months ago

@dvesh3 I have one installation with 10.5.23 where it occures. The 1.6.2 is only compatible with from 10.6. Can you please create also 1.5.2 for 10.5? Thanks!

dvesh3 commented 12 months ago

Sorry, 1.5 branch doesn't exist anymore for 10.5 as it reached EOL. Please use the patch in your project.