search

pimcore / pimcore

Core Framework for the Open Source Data & Experience Management Platform (PIM, MDM, CDP, DAM, DXP/CMS & Digital Commerce)
http://www.pimcore.com
Other
3.25k stars 1.42k forks source link

[Improvement]: further introduce JSON-types for non-primitive data #17104

Open dkarlovi opened 1 month ago

dkarlovi commented 1 month ago

Improvement description

Since #13359, Pimcore will use real JSON data type for data which was already stored as JSON.

This should IMO go further: complex data is now stored as both JSON (now as native JSON type, hopefully?), but also as PHP-serialized (just a string).

IMO, this distinction doesn't provide any real value and only produces complications in day to day operations.

Say you want to test an implementation of #17103 and want to find all duplicated assets. The asset checksum is currently stored in assets.customSettings which is PHP-serialized. If it was JSON, this would be a basic SQL query. Now, this must be a new utility command, we lose by the fact MySQL doesn't see PHP-serialized data as anything but a dumb string.

All the arguments about the data store natively understanding and keeping the integrity of the complex data structure are still valid as they were in #13359.

github-actions[bot] commented 2 weeks ago

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.