pimcore / pimcore

Core Framework for the Open Source Data & Experience Management Platform (PIM, MDM, CDP, DAM, DXP/CMS & Digital Commerce)
http://www.pimcore.com
Other
3.38k stars 1.43k forks source link

[Asset] Image Editor saves image as PNG even when source file is JPEG #4805

Closed SameerPCore closed 5 years ago

SameerPCore commented 5 years ago

Bug Report

Edited Image is not opening after Original File download option

Expected behavior

Image should open without any error

Actual behavior

A format exception is coming after opening the downloaded image

Steps to reproduce

-->Go to asset tab, open an image from left tree view -->Go to edit tab, edit the image and save it. -->Go to preview tab, download the image by clicking on Original File button -->Go to the downloaded file and open it. --> Image doesn't open an error message comes in the bar. See the attach screenshot Screenshot from 2019-08-05 19-13-33

Code example

// your code

Feature Request

Feature description

brusch commented 5 years ago

Just tested on demo.pimcore.org ... works as expected when using the download button:

image

SameerPCore commented 5 years ago

edit a jpg file and download with original file button. Screenshot from 2019-08-05 19-22-49

SameerPCore commented 5 years ago

the issue is very much there it is not working. please see the screen shot testing on demo-advanced.pimcore.org Screenshot from 2019-08-05 19-27-46

brusch commented 5 years ago

Just tested it on demo-basic.pimcore.org (advanced currently not working), works as expected...

SameerPCore commented 5 years ago

Please upload a JPG file and edit and save it. then download it from either download button of toolbar or original file button present on the right panel. The error is very much there. this error is occurring because while editing the format is changed to PNG but the extension of file remains JPG.

dvesh3 commented 5 years ago

@brusch It works fine if you try to open image on Windows default image viewer but reproducible on some softwares so maybe Linux is affected. @SameerPCore is right, this is the issue https://stackoverflow.com/questions/11310220/why-am-i-getting-the-error-not-a-jpeg-file-starts-with-0x89-0x50 image