pimcore / pimcore

Core Framework for the Open Source Data & Experience Management Platform (PIM, MDM, CDP, DAM, DXP/CMS & Digital Commerce)
http://www.pimcore.com
Other
3.31k stars 1.43k forks source link

[DataObject][Numeric] rounding might cause floating issues #5088

Open fashxp opened 4 years ago

fashxp commented 4 years ago

see https://github.com/pimcore/pimcore/blob/257297cc2c6f841926a5219698da6edadfdccb7a/models/DataObject/ClassDefinition/Data/Numeric.php#L583

maybe we should go for pimcore decimal type and return string like e.g. $data = Decimal::create($data, $this->getDecimalPrecision())->asString();

github-actions[bot] commented 6 months ago

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.