search

pimcore / skeleton

The Pimcore Skeleton - The right package to get your Pimcore project started from the ground up! 💪
https://pimcore.com
100 stars 107 forks source link

[Bug]: service "php" can't be used with `extends` as it declare `depends_on` #184

Closed fashxp closed 6 months ago

fashxp commented 7 months ago

Expected behavior

docker compose works with shipped docker-compose.yaml

Actual behavior

fails with error service "php" can't be used with extends as it declare depends_on

see also https://github.com/docker/compose/issues/11544

Steps to reproduce

create project and run docker compose up -d with latest docker compose version

gander commented 7 months ago 
service "php" can't be used with `extends` as it declare `depends_on`
  1. Reason: service test-php extends php that declare depends_on
  2. Error occurs since Docker Compose v2.24.6
  3. Docker Compose documentation: Restrictions
  4. CLOSED, they won't "fix" it: docker/compose#11544
fashxp commented 7 months ago

but there is a PR https://github.com/compose-spec/compose-spec/pull/470 that might fix this again...

jdreesen commented 7 months ago

Which was merged now!

jdreesen commented 6 months ago

compose/issues#11544 is now resolved and it should work again with v2.26.0.

github-actions[bot] commented 6 months ago

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.