search

pimcore / studio-ui-bundle

Studio UI bundle
Other
12 stars 2 forks source link

Prepare mechanism to include CSS/JS files from bundles #222

Closed markus-moser closed 1 month ago

drietsch commented 2 months ago

Just were thinking about https://webpack.js.org/ in that case ;-)

markus-moser commented 2 months ago

@drietsch Yes, this is based on webpack - we cannot easily use webpack encore in this case because of the nature how it works (configuration is added during compling of the container). Therefore we decided to parse the entrypoints.json ourselves for the moment.

markus-moser commented 2 months ago

@drietsch And another aspect is that we want to avoid that someone needs to do a custom node build when someone just installs a bundle, therefore we need to include the built resources ;)

drietsch commented 2 months ago

Sorry, did not want to be a smart ass, @markus-moser ;-)

vin0401 commented 1 month ago

@markus-moser - this PR can be closed, because we already have the changes included in https://github.com/pimcore/studio-ui-bundle/pull/239, right?

markus-moser commented 1 month ago

@markus-moser - this PR can be closed, because we already have the changes included in #239, right?

Right! -> closed