pimcore / studio-ui-bundle

Studio UI bundle
Other
14 stars 5 forks source link

[Versions] Asset metadata missing #352

Closed markus-moser closed 1 month ago

markus-moser commented 3 months ago

The version preview should show asset metadata attributes:

image

Currently they are missing: image

Related to #349

markus-moser commented 3 months ago

@pimcore-studio-backend-team

Please add the asset metadata attributes to the version endpoint so that we can display them in the preview table.

mattamon commented 3 months ago

@markus-moser should we also remove the scheduled tasks since they are actually not versioned?

markus-moser commented 3 months ago

@mattamon We need the scheduled attribute for this view:

image

It might be possible to achieve the same thing when we additionally ask the scheduled tasks API. But this would be a little bit more complex and as we already have it in place I would vote for keeping it.

mattamon commented 3 months ago

@markus-moser Okay got it!

https://github.com/pimcore/studio-backend-bundle/pull/160 I added the missing metadata here. Can you check if this is already enough?

markus-moser commented 3 months ago

@mattamon From what I see in the PR it looks good.

@robertSt7 Could you please check if this is fine?

mattamon commented 3 months ago

@markus-moser I left out the additional attributes, because they make no sense, since they are not versioned. If you still want to have them, please let me know :)

markus-moser commented 3 months ago

@mattamon I think we can leave them out.

mattamon commented 3 months ago

@robertSt7 I am going to merge it so it will be part of 1.x

robertSt7 commented 1 month ago

see https://github.com/pimcore/studio-ui-bundle/pull/430#pullrequestreview-2194110965