search

pimcore / studio-ui-bundle

Studio UI bundle
Other
14 stars 3 forks source link

[Versions] Preview images for non-images #420

Open markus-moser opened 2 months ago

markus-moser commented 2 months ago

E.g. for PDFs the preview image does not work:

image

robertSt7 commented 1 month ago

@markus-moser How should this look like? In the old ui only the document is displayed

markus-moser commented 1 month ago

@robertSt7 That's a good question. We should at least add a download button to all versions independent of the type. In the old system we have something similar for all types where no preview is possible (so for all types except image and PDF):

image

As we now have a different approach we should not make a exception for images and also add the download option there. @idaiv Could you maybe please prepare a screen how a download link/button in the version preview & comparison could look like?

Is it in addition to that possible to display an image thumbnail for Asset\Document previews (so calling getImageThumbnail on the asset model)? When we display this image thumbnail the same way like for images + the download button it would be a nice approach in my opinion.

robertSt7 commented 1 month ago

@markus-moser unfortunately we don't have thumbnails for the Versions of Asset\Document. We can't implement this at the moment

markus-moser commented 1 month ago

@robertSt7 Then let's just add the download button for the moment

idaiv commented 3 weeks ago

Hi Markus! Sorry for the delay on this task. The design is approved and ready for implementation.

Link: https://www.figma.com/design/kTxowT29eCHwNh5NspDGGu/Pimcore-Components?node-id=5459-218562&t=XuuBIvPJ6ynSxhl2-4

markus-moser commented 3 weeks ago

Hi Ida, nice, thanks a lot!