search

pimcore / web-to-print-bundle

Web-to-Print community bundle adds web-to-print features to Pimcore documents.
https://pimcore.com/docs/platform/Web_To_Print/
Other
4 stars 12 forks source link

[Gotenberg] gotenberg/gotenberg-php missing #30

Closed matthiashamacher closed 1 year ago

matthiashamacher commented 1 year ago

If you want to use the gotenberg Adapter it is currently not working because the gotenberg/gotenberg-php package is only installed in dev.

Either the package needs to be moved to require or the documentation needs to be updated that the package needs to be installed manually in the project to use the adapter.

The Chromium adapter potentially has the same issue, but I haven't checked that.

I'm willing to make the required changes but need input which way you want to go.

kingjia90 commented 1 year ago

Thank you for the report!

We were coincidentally working on improving a little bit the documentation , but in the meanwhile, if you could add some links to the core from this bundle in the installation page that would be great.

Won't be bad if the entries composer suggest are also copied in the composer of this bundle, right? there's no sort of "inheritance" or so?

matthiashamacher commented 1 year ago

@kingjia90 Added some more documentation and the suggest. I would also propose to at least remove the suggest for the chromium dependency from pimcore/pimcore as it is not required for the core. As gotenberg can be used for the document preview I think that one can stay.