search

pimentel / atom-r-exec

Send R code to various R consoles from the Atom editor
https://atom.io/packages/r-exec
MIT License
19 stars 8 forks source link

Advance position skips lines that end with # comments #38

Closed ekhco closed 7 years ago

ekhco commented 7 years ago 
head(inertial_signals_test[[1]])
nrow(inertial_signals_test[[1]])   # 2947 samples
ncol(inertial_signals_test[[1]])   # 128 cols

table(y_test)

In the above code, if the Cursor is on the first line, and Advance Position == TRUE, then it skips over line 2,3 to line 5.

pimentel commented 7 years ago

Gah. Good find. This seems like an easy fix -- I will update this weekend.

Thanks.

pimentel commented 7 years ago

Fixed in the master branch (you can install this if you would like).

I will push a patch in the coming days after fixing a few other minor bugs.

Thanks again,

Harold

ekhco commented 7 years ago

nice! thanks - awesome package btw.

a suggested feature: perhaps you could allow the user to set different keystrokes to send to different Apps. ie: cmd+enter: R.app, shift+cmd+enter: Terminal

On Mon, Dec 5, 2016 at 1:30 PM, Harold Pimentel notifications@github.com wrote:

Fixed in the master branch (you can install this if you would like).

I will push a patch in the coming days after fixing a few other minor bugs.

Thanks again,

Harold

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pimentel/atom-r-exec/issues/38#issuecomment-264935519, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlKL1hce_q_gdHtQa4uSWIF4CeG6629ks5rFFgwgaJpZM4LC1zC .

pimentel commented 7 years ago

Great idea. The initial version of this project had different keys bound to different destinations which made it a bit confusing. I think I will basically support commands and allow the user to bind those themselves.

Opened issue #40